Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Float64BufferAttribute. #27807

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Remove Float64BufferAttribute. #27807

merged 1 commit into from
Feb 23, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 22, 2024

Related issue: #27805, #23006

Description

WebGL does not support processing double precision floating point buffer data. The renderer is also unable to process Float64BufferAttribute so I think it's best to remove the class. Otherwise it just causes further confusion.

@Mugen87 Mugen87 added this to the r162 milestone Feb 22, 2024
Copy link

github-actions bot commented Feb 22, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
678.2 kB (168.6 kB) 678.1 kB (168.6 kB) -100 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
458.5 kB (111.3 kB) 458.5 kB (111.3 kB) +0 B

@mrdoob
Copy link
Owner

mrdoob commented Feb 23, 2024

Can't even find when it was added 😅

@mrdoob mrdoob merged commit 289444e into mrdoob:dev Feb 23, 2024
12 checks passed
@gkjohnson
Copy link
Collaborator

Looks like 10 years ago 😆

f549fed

@mrdoob
Copy link
Owner

mrdoob commented Feb 23, 2024

Almost exactly! Amazed that it lasted that long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants