Playground: Implement a splitscreen #27784
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Fixed. I had to wrap the renderer DOM element into another div for this, let me know if there is a better way to do this.
Fixed, it does now return to the original view as demanded. |
|
The DeepScan check fails on an issue that seems to be totally unrelated to this PR - or am I overlooking something? |
|
A rebase would solve the issue. But yes, it's unrelated to your changes. |
| const container = document.createElement( 'div' ); | ||
| container.className = 'splitview'; | ||
|
|
||
| document.body.appendChild( container ); |
There was a problem hiding this comment.
We can use this.domElement instead of document.body here and in others appends? This would make the editor more flexible if we added it embed in editor for exemple. I think we can do the same thing with the classes, for example: flow splitview intead of just splitview.
There was a problem hiding this comment.
this.domElement is null in the context of the script (which is directly embedded into the html). Thus, I am not sure how to implement that, can you give me a hint?
|
It's looking really cool, I think it would be the last details I saw. |
playground/NodeEditor.js
Outdated
| @@ -297,7 +339,7 @@ export class NodeEditor extends THREE.EventDispatcher { | |||
|
|
|||
| previewMenu.add( editorButton ); | |||
|
|
|||
| this.domElement.append( menu.dom ); | |||
| document.body.appendChild(menu.dom); | |||
There was a problem hiding this comment.
We need to move the menus to domElement in order to maintain the consistency of the hierarchy.
There was a problem hiding this comment.
If you can follow the name style could be better intead of div, could remove some redundant classes name too. Something like this:
node-editor is domElement in this case
- node-editor
- f-preview ( instead of splitview )
- flow
- f-menu
There was a problem hiding this comment.
Updated.
f-menu still lives in flow, because otherwise i would have to keep track of when the editor gets added in order to then add f-menu to the domElement parent.
is it fine like that?
Description
Feature proposal for a (resizable) splitscreen for the playground:
Currently, there are two ways to display results of the node trees:
Something I found annoying during my experiments is that often times, I wanted to see the results when plugging various nodes around for experimentation. The first display option requires an additional click/hotkey (and a little do-after because of the node-pop-up animation when the editor opens back up). The second option only allows to show a single node. A splitscreen allows to see the results of plugging instantly.
I am open for suggestions and discussion :)