-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGLRenderer: Add Support for Khronos Neutral Tone Mapping #27668
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Add support for `CommereceToneMapping`.
Add support for `CommerceToneMapping`.
@elalish I've added two minor changes to your branch to make sure |
Add reference for `CommerceToneMapping`.
Great tone mapper! However, as discussed offline... I'm not a fan of the "Commerce" name and would very much prefer renaming it to something like "Neutral" before it's not too late 😇 Maybe "Khronos' Neutral Tone Mapper"? |
For anyone curious, the tonemapping can also be tried out here, across a wide range of Khronos sample models:
|
To be less verbose, maybe Anyway, the docs should be updated. |
What @WestLangley said 👍 |
I'll merge and clean up. |
Thanks! |
This is the tone mapper I designed for color-accuracy and that we are working to make a standard through the Khronos 3D Commerce group. In-depth writeup here. The summary is this is an improved alternative to No/Linear/Clamped tone mapping. It preserves the baseColor sRGB values as faithfully as possible through to the final render under uncolored lighting.
Improvements over No tone mapping:
Improvements over ACES/AgX:
Situations where AgX is a better choice:
I've already shipped this in
<model-viewer>
and I intend to make it our default in v4.0. You can test it yourself by drag-and-dropping any GLB and HDR into this Glitch.FYI @mrdoob @WestLangley @donmccurdy @bhouston @hybridherbst