Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: cleanup, add maxGeometryCount member #27231

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #22376, #27228

Description

  • Add maxGeometryCount as a public, readonly member
  • Remove unused getter functions (can be readded when we find a use)
  • Update documentation
  • Linting in batched mesh example

@gkjohnson gkjohnson added this to the r159 milestone Nov 23, 2023
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
668.6 kB (165.9 kB) 668.4 kB (165.8 kB) -283 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.6 kB (108.9 kB) 449.6 kB (108.9 kB) +0 B

@gkjohnson gkjohnson merged commit 1310548 into mrdoob:dev Nov 23, 2023
12 checks passed
@gkjohnson gkjohnson deleted the batched-members-docs branch November 23, 2023 09:16
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
* Linting, add maxGeometryCount to BatchedMesh, remove undocumented functions

* BatchedMesh: Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants