Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lottie: Add document check for SSR. #26989

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

CodyJasonBennett
Copy link
Contributor

@CodyJasonBennett CodyJasonBennett commented Oct 16, 2023

Related issue: #XXXX

Description

Similar to #26915, Lottie has top-level effects which do not work in SSR.

With #26910, I tested with node examples/jsm/Addons.js which should run without error.

@Mugen87 Mugen87 added this to the r158 milestone Oct 16, 2023
@Mugen87 Mugen87 merged commit de5932e into mrdoob:dev Oct 17, 2023
19 checks passed
@CodyJasonBennett CodyJasonBennett deleted the lottie-ssr branch October 17, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants