WebGPURenderer: Revert and fix updateBefore() - (2) #26422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Jul 14, 2023
|
|
||
| // | ||
|
|
||
| object.modelViewMatrix.multiplyMatrices( camera.matrixWorldInverse, object.matrixWorld ); |
There was a problem hiding this comment.
Wouldn't these lines be called twice in case of double-pass transparent rendering?
There was a problem hiding this comment.
Wouldn't these lines be called twice in case of double-pass transparent rendering?
The updateBefore() can made RTT because of some nodes, and this can affect the current modelViewMatrix, I'll improve this once I have a better idea, I'm currently prioritizing stability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26417, #26391
Description
I think it's the last fix for
updateBefore()in that sense, seems the best approach.The latest updates although fix some problems brought others in
viewportTexture(), this PR looks like a general fix.