-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json: Don't export examples/fonts
directory
#26048
Conversation
If there is demand for keeping it (I wouldn't know), might be worth republishing under a separate package - not sure how trivial that is with current instrumentation scripts, though. |
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Not including I think fonts can be removed but it would be good if @mrdoob or @WestLangley could double check this. |
We can't remove the fonts folder, people are using it. See #23354 |
Apart from the aggregate cost of it all (est ~2TB post-extraction through NPM daily), there are scenarios where constraints make size become a real issue and potential blocker. It is, of course, valid for
So between that, and the closing without further discussion of these to PRs, I guess we now have much more clarity on the upcoming few years of
Agreed this would be a breaking change that requires communication to users. What I'd suggest might be something along the lines of for example:
Just saying it's possible to do in a way that has minimal impact on users - eating the cake and having it. It might be useful to know if something like this might ever be considered at some point. But again (and I hope it goes without saying), "not in scope, sort out your own builds" is a valid response and for now I guess this is put to rest. I hope this and the initial buzz isn't considered noise. Thank you for listening to my ted talk. |
Another possible option would be to keep the interface and |
I have a hard time reading your posts / writing style. I've not read them and instead I've asked chatgpt to summarize:
Yes, I agree with that. |
Related issue: #20019 (comment)
Description
I don't really understand why we need it...