fix sky shader at non-zero origins #26045
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok, so the sky "as is" only works when placed at 0,0,0
when you move it with the camera somewhere far, far away - you get this:
this change fixes it to what it looks like at 0,0,0 again:
personally, I would also replace BoxGeometry with SphereGeometry because the box edges are too visible, but that is separate issue (and you could maybe also address that in the shader instead).