-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Unit Tests for Helpers #25398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrowHelper extends from Object3D. ArrowHelper.type should be ArrowHelper. Stub missing member tests.
AxesHelper extends from LineSegments. AxesHelper.type should be AxesHelper. Stub missing member tests.
Box3Helper extends from LineSegments. Box3Helper.type should be Box3Helper. Stub missing member tests.
BoxHelper extends from LineSegments. BoxHelper.type should be BoxHelper. Stub missing member tests.
CameraHelper extends from LineSegments. CameraHelper.type should be CameraHelper. Stub missing member tests.
DirectionalLightHelper extends from Object3D. DirectionalLightHelper.type should be DirectionalLightHelper. Stub missing member tests.
GridHelper extends from LineSegments. GridHelper.type should be GridHelper. Stub missing member tests.
HemisphereLightHelper extends from Object3D. HemisphereLightHelper.type should be HemisphereLightHelper. Stub missing member tests.
PlaneHelper extends from Line. PlaneHelper.type should be PlaneHelper. Stub missing member tests.
PointLightHelper extends from Mesh. PointLightHelper.type should be PointLightHelper. Stub missing member tests.
PolarGridHelper extends from LineSegments. PolarGridHelper.type should be PolarGridHelper. Stub missing member tests.
SkeletonHelper extends from LineSegments. SkeletonHelper.type should be SkeletonHelper. SkeletonHelper.isSkeletonHelper should be true. Stub missing member tests.
SpotLightHelper extends from Object3D. SpotLightHelper.type should be SpotLightHelper. Stub missing member tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Helpers.
Fills in some unit tests, populates the missing member tests with stubs.