Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Unit Tests for Helpers #25398

Merged
merged 13 commits into from
Feb 2, 2023
Merged

Tests: Unit Tests for Helpers #25398

merged 13 commits into from
Feb 2, 2023

Conversation

epreston
Copy link
Contributor

@epreston epreston commented Feb 1, 2023

Related issue: none.

Description

This cleans up the unit tests for Helpers.
Fills in some unit tests, populates the missing member tests with stubs.

ArrowHelper extends from Object3D.
ArrowHelper.type should be ArrowHelper.
Stub missing member tests.
AxesHelper extends from LineSegments.
AxesHelper.type should be AxesHelper.
Stub missing member tests.
Box3Helper extends from LineSegments.
Box3Helper.type should be Box3Helper.
Stub missing member tests.
BoxHelper extends from LineSegments.
BoxHelper.type should be BoxHelper.
Stub missing member tests.
CameraHelper extends from LineSegments.
CameraHelper.type should be CameraHelper.
Stub missing member tests.
DirectionalLightHelper extends from Object3D.
DirectionalLightHelper.type should be DirectionalLightHelper.
Stub missing member tests.
GridHelper extends from LineSegments.
GridHelper.type should be GridHelper.
Stub missing member tests.
HemisphereLightHelper extends from Object3D.
HemisphereLightHelper.type should be HemisphereLightHelper.
Stub missing member tests.
PlaneHelper extends from Line.
PlaneHelper.type should be PlaneHelper.
Stub missing member tests.
PointLightHelper extends from Mesh.
PointLightHelper.type should be PointLightHelper.
Stub missing member tests.
PolarGridHelper extends from LineSegments.
PolarGridHelper.type should be PolarGridHelper.
Stub missing member tests.
SkeletonHelper extends from LineSegments.
SkeletonHelper.type should be SkeletonHelper.
SkeletonHelper.isSkeletonHelper should be true.
Stub missing member tests.
SpotLightHelper extends from Object3D.
SpotLightHelper.type should be SpotLightHelper.
Stub missing member tests.
@mrdoob mrdoob added this to the r150 milestone Feb 2, 2023
@mrdoob mrdoob merged commit b52bef4 into mrdoob:dev Feb 2, 2023
@epreston epreston deleted the tests-helpers-cleanup branch February 2, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants