Tests: Unit Tests for Math #25385
Merged
Tests: Unit Tests for Math #25385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test fixture, 'math/Constants.tests.js' wasnt a test file but a set of fixures used by: animation/AnimationMixer.tests.js core/BufferGeometry.tests.js core/Object3D.tests.js core/Uniform.tests.js math/Box2.tests.js math/Box3.tests.js math/Color.tests.js math/Cylindrical.tests.js math/Euler.tests.js math/Frustum.tests.js math/Line3.tests.js math/Matrix4.tests.js math/Plane.tests.js math/Quaternion.tests.js math/Ray.tests.js math/Sphere.tests.js math/Spherical.tests.js math/Triangle.tests.js math/Vector2.tests.js math/Vector3.tests.js math/Vector4.tests.js Shared math constants for tests moved to utils. Only tests in test source.
Add unit tests for ColorManagement
Add unit tests for SphericalHarmonics3
CubicInterpolant extends from Interpolant. Add missing member tests and stubs.
DiscreteInterpolant extends from Interpolant. Add missing member tests and stubs.
QuaternionLinearInterpolant extends from Interpolant. Add missing member tests and stubs.
LinearInterpolant extends from Interpolant. Add missing member tests and stubs.
Add missing member test.
Stub missing member tests. Source ordering. Group all functional tests under "Others".
Stub missing member test.
Review.
Stub missing member test. Update old names in test description.
Stub missing member tests. Source ordering.
Stub missing member tests.
Add missing member test.
Stub missing member test. isInterestionLine does not exist, intersectLine does not test the boolean variant with an extra S, intersectsLine.
Stub missing member tests.
Stub missing member test. Correct typo.
isSpherical does not exist on Spherical. Add missing member test.
Stub missing static and member tests. Both are API even if one calls the other.
isSphere does not exist on Sphere.
isRay does not exist on Ray.
Fill in member tests. Rename test title to reflect recent changes in API.
Stub missing member tests. Source ordering.
Fill in member test.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
I'm going to agree with Code scanning / CodeQL and use a more specific test.
|
Are we running 8 of the same E2E tests ? Each operating system appears 8 times. |
|
Yes, we run 8 tests on each of 3 OSes. |
|
What's the difference between them ? Is it to find variance in images generated ? |
|
Each runs on the 1/8'th of all examples -- it would be too slow to combine them into one test without parallelization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
This cleans up the unit tests for Math.
Adds missing unit test files, fills in some unit tests, populates the missing member tests with stubs.
A test fixture, 'math/Constants.tests.js' wasnt a test file but a set of fixures used by:
animation/AnimationMixer.tests.js
core/BufferGeometry.tests.js
core/Object3D.tests.js
core/Uniform.tests.js
math/Box2.tests.js
math/Box3.tests.js
math/Color.tests.js
math/Cylindrical.tests.js
math/Euler.tests.js
math/Frustum.tests.js
math/Line3.tests.js
math/Matrix4.tests.js
math/Plane.tests.js
math/Quaternion.tests.js
math/Ray.tests.js
math/Sphere.tests.js
math/Spherical.tests.js
math/Triangle.tests.js
math/Vector2.tests.js
math/Vector3.tests.js
math/Vector4.tests.js
Shared math constants for tests moved to utils. Only tests in test source. This also removes the confusion with the actual 'Constants.tests.js' file in the parent directory.