Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Unit Tests for Textures #25365

Merged
merged 18 commits into from
Jan 30, 2023
Merged

Tests: Unit Tests for Textures #25365

merged 18 commits into from
Jan 30, 2023

Conversation

epreston
Copy link
Contributor

Related issue: none

Description

Following the second pull request to nail down the process, this cleans up the unit tests for Textures.
It fills in one working unit test for each (up from 0) and populates the missing member tests with stubs.

Add unit test file for textures/FramebufferTexture
Add missing properties and describe how they differ from the base class, Texture.
Add example code, link to full example, add property that differs from base class.
DepthTexture extends from Texture
FramebufferTexture extends from Texture
CanvasTexture extends from Texture
Add missing property test stubs.
CompressedTexture extends from Texture
Add missing property test stubs.
Add missing unit test file, one complete test to show its working, stubs for members.
CubeTexture extends from Texture
Add missing unit test file, one complete test to show its working, stubs for members.
Add missing unit test file, one complete test to show its working, stubs for members.
Link to added unit tests.
DataTexture extends from Texture
Texture extends from EventDispatcher. Add missing property and method test stubs.
VideoTexture extends from Texture.  Add missing properties and method test stubs.
Separate INHERITANCE and INSTANCING tests.
@mrdoob mrdoob added this to the r150 milestone Jan 30, 2023
@mrdoob mrdoob merged commit 1f4311d into mrdoob:dev Jan 30, 2023
@epreston epreston deleted the texts-textures-cleanup branch January 30, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants