Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Add GLTFExporter example for KHR_mesh_quantization #25354

Merged

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Jan 28, 2023

Related:

Description

Updates the webgl / exporter / gltf example, replacing the OBJ model in the scene with a GLB that requires KHR_mesh_quantization support to export. The export fails now, but will work after #25297. Instead of adding another model to the repository, I've replaced an existing GLB with a quantized version:

gltf-transform quantize input.glb output.glb

@donmccurdy donmccurdy force-pushed the feat/gltfexporter-example-KHR_mesh_quantization branch from 956a41b to 5810e09 Compare January 28, 2023 22:26
@Mugen87 Mugen87 added this to the r150 milestone Jan 29, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 29, 2023

Since an asset has been exchanged, the E2E screenshot requires an update.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 29, 2023

I'll merge and update 👍 .

@Mugen87 Mugen87 merged commit 18ef296 into mrdoob:dev Jan 29, 2023
@Mugen87 Mugen87 mentioned this pull request Jan 29, 2023
@donmccurdy donmccurdy deleted the feat/gltfexporter-example-KHR_mesh_quantization branch January 30, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants