Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppeteer E2E test: Clean up #25314

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Puppeteer E2E test: Clean up #25314

merged 5 commits into from
Jan 30, 2023

Conversation

LeviPesin
Copy link
Contributor

Related issue: #24109 (comment)

Description

The first part from #24109 -- just a cleanup. (Also adds idleTime and parseTime variables.)

@mrdoob mrdoob added this to the r149 milestone Jan 21, 2023
@LeviPesin
Copy link
Contributor Author

@mrdoob @Mugen87 Please merge this PR so that I can file the remaining Puppeteer PRs which are dependent on this one.

@mrdoob mrdoob modified the milestones: r149, r150 Jan 26, 2023
@mrdoob mrdoob merged commit 607d6b0 into mrdoob:dev Jan 30, 2023
@LeviPesin LeviPesin deleted the puppeteer-cleanup branch January 30, 2023 11:10
@LeviPesin
Copy link
Contributor Author

LeviPesin commented Jan 30, 2023 •
edited
Loading

Thank you! Going to file other Puppeteer PRs now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r150
Development

Successfully merging this pull request may close these issues.
2 participants
@LeviPesin @mrdoob