-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand lint scripts #25251
Expand lint scripts #25251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
CodeQL alerts on this PR because linting changes in some files trigger it (CodeQL thoughts that issues were both removed and added). |
The number of lines changed is scary 😅 |
I recommend making smaller PRs with a smaller sets of files linted per PR so the change set is more approachable. And then a separate PR with an automated lint process added. The |
Agreed! It's always hard to review such large PRs. It's easy to overlook something so smaller change sets are preferable. I would exclude linting |
Reverted the lint changes to manual. Can this PR be reopen, please? |
I think it would be also better to revert the changes to |
Done. |
Related issue: -
Description
Expand lint test to include tests for addons, docs, and other directories. This PR also changes main
lint
script so these tests are ran bynpm run lint
(and therefore the lint test in the actions).