Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMDLoader: Use matcap instead of envMap. #25226

Merged
merged 1 commit into from
Jan 4, 2023
Merged

MMDLoader: Use matcap instead of envMap. #25226

merged 1 commit into from
Jan 4, 2023

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Jan 4, 2023 •
edited
Loading

Description

MMDLoader replaced envMap with matcap before because it matches the MMD spec more. But MMDLoader still uses some envMap because we seemed to have overlooked.

This PR replaces the remained envMap with matcap.

After this PR will be merged, #25128 can be merged because envMap will be no longer used with MMDLoader.

@takahirox takahirox mentioned this pull request Jan 4, 2023
Merged
@WestLangley WestLangley added this to the r149 milestone Jan 4, 2023
@Mugen87 Mugen87 merged commit b825f42 into mrdoob:dev Jan 4, 2023
@Mugen87 Mugen87 changed the title MMDLoader: Use matcap instead of envMap MMDLoader: Use matcap instead of envMap. Jan 4, 2023
@takahirox takahirox deleted the FixPMDMatcap branch January 4, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r149
Development

Successfully merging this pull request may close these issues.
3 participants
@takahirox @WestLangley @Mugen87