ArcballControls: Fix code style. #25182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
ArcballControls
does some strange method definitions inside its class. They look like so:The class does this so it can directly use the method for an event listener (to retain the
this
reference). However, the same pattern is applied to methods which are not intended as event listeners. This is actually breaks eslint on my system and I think it's also confusing to use arrow functions like that.Event listeners are now normal functions like in other controls and the above pattern is completely removed from the class.