-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Clean up #25057
Examples: Clean up #25057
Conversation
return item != undefined && item != null; | ||
return item !== undefined && item !== null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed in the original repository.
cc @agviegas - does it make sense to use something like "unpkg" and import maps in the example rather than copying the build into three.js examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Seems like the loader in the repo is a bit old now too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, that's right! The project is growing a lot, and chances are that next year it will take off. To avoid bloating three.js and to have a single source of truth, maybe it's a better idea to keep it outside of three.js, like three-mesh-bvh? 🤔 What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's best - the three.js examples are still a good way to enable people to discover the external projects, though. The ifc js project can be modified to use an import map like the three-mesh-bvh raycasting example here:
three.js/examples/webgl_raycaster_bvh.html
Lines 31 to 39 in 309b00a
<script type="importmap"> | |
{ | |
"imports": { | |
"three": "../build/three.module.js", | |
"three/addons/": "./jsm/", | |
"three-mesh-bvh": "https://unpkg.com/three-mesh-bvh@^0.5.10/build/index.module.js" | |
} | |
} | |
</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! Should I update the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my opinion - then we can delete the ifc.js files from the project and direct users to use the canonical, up to date repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrdoob got it!
Done: #25440 🙂 |
Description
Some clean up based on the output of #25056.