Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstancedBufferGeometry: Remove unused argument from super.toJSON() #24948

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Nov 13, 2022

Its base class .toJSON() takes no argument:

toJSON() {
const data = {
metadata: {
version: 4.5,
type: 'BufferGeometry',
generator: 'BufferGeometry.toJSON'
}
};
// standard BufferGeometry serialization

@Mugen87 Mugen87 added this to the r147 milestone Nov 14, 2022
@Mugen87 Mugen87 merged commit d11830c into mrdoob:dev Nov 14, 2022
@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 14, 2022

Looking at the code: It seems InstancedBufferGeometry.clone() can be removed since BufferGeometry.clone() has the same implementation.

@ycw ycw deleted the instancedbuffergeometry-unused-args0 branch November 14, 2022 10:39
@mrdoob
Copy link
Owner

mrdoob commented Nov 15, 2022

@Mugen87 Removed! b58ecfd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants