-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OctreeHelper: Add update()
.
#24641
OctreeHelper: Add update()
.
#24641
Conversation
…e.js into octree-helper-update
The TBH, I'm thinking that adding a This class can't be simply updated -- a new instance is generally required. It is the app's responsibility to call At least, that has been our policy. Without a consistently-implemented policy, users will never know when calling |
I've also thought about this although other helpers do have update methods. I'm okay for both approaches in context of |
Some helpers have a |
I don't think that something like |
But the update methods just update the buffer data. In this case, I think an I would prefer to see a |
Added |
Related issue: #23481
When Octree changes, you need to recreate another OctreeHelper. This PR adds an
update()
method to rebuild the visualization on the same geometry.