Add triangle draw Modes to documentation #24429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Aug 3, 2022
| THREE.TriangleFanDrawMode | ||
| </code> | ||
| <p> | ||
| [page:constant TrianglesDrawMode] is the mode to draw a series of separate triangles. <th></th><br /> |
There was a problem hiding this comment.
There was a problem hiding this comment.
So these constants should only be documented in BufferGeometry.toTrianglesDrawMode() documentation, correct?
There was a problem hiding this comment.
That's probably the best choice. Otherwise users might think they can actually define the draw mode for meshes via those constants which is not supported.
There was a problem hiding this comment.
Closing the PR and fix the docs with a new one.
|
TriangleStrip is very important for performance reasons. Inability to render them is a significant problem for some projects. |
Do you have any benchmarks that demonstrate that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24418
Description
This adds the triangle draw Modes to documentation.