-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPURenderer: Particles example #24247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Jun 19, 2022
LeviPesin
reviewed
Jun 19, 2022
Mugen87
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mrdoob
reviewed
Jun 20, 2022
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* reuse buffer used in others mesh/sprite * update geometry if was disposed on renderer process * add initial value for timer * Add RotateUVNode * SpriteNodeMaterial: move .positionNode to work like particles * WebGPURenderer: fix AdditiveBlending * WebGPU: particles example * cleanup * cleanup * fix title * cleanup * cleanup
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* reuse buffer used in others mesh/sprite * update geometry if was disposed on renderer process * add initial value for timer * Add RotateUVNode * SpriteNodeMaterial: move .positionNode to work like particles * WebGPURenderer: fix AdditiveBlending * WebGPU: particles example * cleanup * cleanup * fix title * cleanup * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was relatively easy to create particles using
NodeMaterial
system.I created a fire example.
Live
https://raw.githack.com/sunag/three.js/dev-webgpu-particles-v1/examples/webgpu_particles.html
Commits
Possible issues
64-bits
precision, long values can generate flickersMesh
instead ofSprites
for not overloadGeometryBuffers
shared.blendModes
.This contribution is funded by Google via Igalia