Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Particles example #24247

Merged
merged 12 commits into from
Jun 24, 2022
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 19, 2022

Description

It was relatively easy to create particles using NodeMaterial system.
I created a fire example.

Live

https://raw.githack.com/sunag/three.js/dev-webgpu-particles-v1/examples/webgpu_particles.html

image

Commits

Possible issues

  • Nodes: add 64-bits precision, long values can generate flickers
  • Nodes: Use Mesh instead of Sprites for not overload GeometryBuffers shared.
  • WebGPU: Create an example to check all blendModes.

This contribution is funded by Google via Igalia

@sunag sunag added this to the r142 milestone Jun 19, 2022
@sunag sunag marked this pull request as ready for review June 19, 2022 18:11
@sunag
Copy link
Collaborator Author

sunag commented Jun 20, 2022

@mrdoob @Mugen87 Something that I can improve here?

Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunag sunag merged commit ec597f6 into mrdoob:dev Jun 24, 2022
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* reuse buffer used in others mesh/sprite

* update geometry if was disposed on renderer process

* add initial value for timer

* Add RotateUVNode

* SpriteNodeMaterial: move .positionNode to work like particles

* WebGPURenderer: fix AdditiveBlending

* WebGPU: particles example

* cleanup

* cleanup

* fix title

* cleanup

* cleanup
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
* reuse buffer used in others mesh/sprite

* update geometry if was disposed on renderer process

* add initial value for timer

* Add RotateUVNode

* SpriteNodeMaterial: move .positionNode to work like particles

* WebGPURenderer: fix AdditiveBlending

* WebGPU: particles example

* cleanup

* cleanup

* fix title

* cleanup

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants