WebGPU: Fix wrong auto dimension on MacOS while generate MipMaps #24135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ping @mrdoob |
|
@sunag Could you test this again and double check that the version of Canary on MacOS and Windows is the same? If they're the same we should report the bug to Chrome. |
sunag
added a commit
to sunag/three.js
that referenced
this pull request
Jun 1, 2022
…oob#24135)" This reverts commit 44d2ec9.
Now we have the same behavior in both operation system, the problem now presents in Tested on: |
|
That's good. Thanks for testing! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix wrong auto dimension on
MacOSwhile generateMipMapsEDIT: They assume a wrong self dimension for this context. The bug seems to be on
Windowswhich assumes the2ddimensioneven this being acubeautomatically if this is not sent in the object.To reproduce this bug on
Windowsjust put forsrcView:dimension: GPUTextureViewDimension.CubeMaybe this parameter should be made explicit in the future?
This contribution is funded by Google via Igalia