-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RGBELoader: Simplify texture configuration. #24032
Conversation
Without studying the code in depth... Wouldn't this break this if |
@mrdoob RGBELoader support Float or HalfFloat only |
I see... How about this clean up then? switch ( texture.type ) {
case FloatType:
case HalfFloatType:
texture.encoding = LinearEncoding;
texture.minFilter = LinearFilter;
texture.magFilter = LinearFilter;
texture.generateMipmaps = false;
texture.flipY = true;
break;
} |
@mrdoob the current clean up will remove switch check too, because of the type check already in the parse function |
Right, but my suggestion would only change the properties in the cases we know that need to be changed. |
@mrdoob 👌🏻 |
Thanks! |
* fix mrdoob#24017 : clean RGBELoader code * [misc]: RGBELoader code clean Co-authored-by: ouyanghaozhu <[email protected]>
Fixed #24017
Description
clean RGBELoader unused code