-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Add SelectionHelper for Viewport. #23902
Conversation
Looking good! The only thing I have noticed is that Lines 188 to 192 in f9d1f84
|
Good job. Thank you for your advice. I wasn't aware of |
Thanks! |
Renamed |
The editor broke because there is a lot of references to |
* wip(editor): Add SelectPlugin for Editor. * fix(editor): Fixed SelectionHelper priority to minimum priority. * Remove useless code. * fix(editor): Remove SelectionHelper priority. * Clean up. * Clean up. * Clean up. * Fix error. * Rename intersects -> intersectionsDetected * Add SelectionHelper for sw.js
Related issue: #23464
Description
I'm not sure this is the best implementation of the SelectionHelper component.
Other plugin can receive
raycaster.intersectObjects
in#viewport
withSignal intersects
function like:If there is no problem, I will continue to implement plugin register API.
Please provide feedback.
Todo List
Signal intersects
function in Editor.js.Provide the method to prevent execute SelectionHelper logic, like DOM event'spreventDefault()
.