Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLCapabilities: Use mediump by default #22003

Closed
wants to merge 2 commits into from
Closed

WebGLCapabilities: Use mediump by default #22003

wants to merge 2 commits into from

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Jun 16, 2021

Description

This PR is just to see what would break if we used mediump by default and also to test if there are any performance improvements.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 17, 2021

https://raw.githack.com/mrdoob/three.js/mediump/examples/index.html

@marcofugaro
Copy link
Contributor

Hmm, wonder what's the discussion that led to this test

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 17, 2021

Some context: #14570

@mrdoob
Copy link
Owner Author

mrdoob commented Jun 17, 2021

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 17, 2021

There seems to be artifacts with certain demos (tested with Pixel 4a). E.g.

https://raw.githack.com/mrdoob/three.js/mediump/examples/webgl_lights_rectarealight.html (34fps)

Screenshot_20210617-104604

https://threejs.org/examples/webgl_lights_rectarealight.html (18fps)

Screenshot_20210617-104655

Probably because of #14570 (comment).

@mrdoob mrdoob added this to the rXXX milestone Jun 17, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 17, 2021

@mrdoob mrdoob closed this Jan 14, 2022
@mrdoob mrdoob deleted the mediump branch January 14, 2022 05:07
@mrdoob mrdoob removed this from the r??? milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants