Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSShadowPass (screen space shadow) #21951

Draft
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

gonnavis
Copy link
Contributor

@gonnavis gonnavis commented Jun 5, 2021

@gonnavis
Copy link
Contributor Author

gonnavis commented Jun 6, 2021

Another branch that trying to use MeshBasicMaterial and pure screen-space-lighting-and-shadowing.

Demo: https://raw.githack.com/gonnavis/three.js/SSLightPass/examples/webgl_postprocessing_ssshadow.html
image

@lyonsno
Copy link

lyonsno commented Nov 3, 2021

Hey @gonnavis, this is a cool technique, are you still working on it? Is there any way I could contribute?

@gonnavis
Copy link
Contributor Author

gonnavis commented Nov 5, 2021

Hello @lyonsno, currently it lacks a lot of feature, such as:

  1. Selective: Like which already implemented in SSRPass and SSRrPass.
  2. Blur shadow: Especially for hide screen-space flaws at shadow's edge.
  3. More light types: Such as DirectionalLight.
  4. Compatible with lights parameters which already in THREE.js, prevent create new lights.
  5. PBR, MRT, and so on.

But recently I may have not enough time and ability to do all these.
If you interested in, feel free to keep developing and make new PRs, very welcome!


};

var SSShadowDepthShader = {
Copy link

@lyonsno lyonsno Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this declared using var?

Copy link
Contributor Author

@gonnavis gonnavis Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's copy-pasted from old SSRShader.js, should be ok with let const.

@mrdoob mrdoob added this to the r??? milestone Mar 9, 2022
@andreasrosdal
Copy link
Contributor

SSShadowPass looks amazing, I would like to use this in Fciv.net to implement shadows. I therefore hope this could be merged and included in the next Three.js release please.

https://github.com/fciv-net/fciv-net
https://www.fciv.net

@gonnavis
Copy link
Contributor Author

gonnavis commented Jul 12, 2022

@andreasrosdal Thanks! I'll try to ship a basic version first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants