-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced Google Closure compiler with Terser #20354
Conversation
This comment has been minimized.
This comment has been minimized.
Please consider #15176 (comment). I'm afraid the existence of |
All users who use a build system will now miss the constant replacement (since they use |
Damn. I didn't think of that. |
I'll do some measurements to see what filesize savings these provide. |
Question: Didn't you add the constant replacement primarily for performance reasons? I thought it would be faster to just embed the value instead of looking it up over the |
I think the original intent was filesize savings, but performance improvements was a side effect that I forgot. I guess I'll revert that too haha 😅 Although I know that sometimes when debugging your project you find yourself having to look up these constants. But I haven't heard anyone mentioning that recently. |
Well, that fixed it. I don't even want to know why that happened. |
@Mugen87 looks good to you? |
BTW: I've switched to Terser since a while now because of the easier rollup integration and made good experiences 👍 . |
Giving Terser a try, we can revert if we bump into problems.
This simplifies the build setup so it's all done inside rollup now.
The script also automatically adds the
// threejs.org/license
header so we won't have to worry about it anymore.