Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Fix webgl_buffergeometry_instancing_lambert. #18802

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 3, 2020

Fixed #18801.

@mrdoob mrdoob added this to the r115 milestone Mar 3, 2020
@mrdoob mrdoob merged commit 9c7b4f4 into mrdoob:dev Mar 3, 2020
@mrdoob
Copy link
Owner

mrdoob commented Mar 3, 2020

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Mar 3, 2020

Hmm...

@WestLangley I think this example is confusing now as there is a simpler way to do this (just use InstancedMesh). Do you think it is still needed?

@WestLangley
Copy link
Collaborator

I promoted it because it shows how to hack an existing shader, and perhaps more importantly, a custom depth shader.

I also promoted it because it avoids using String.replace() to inject code snippets. This approach is more-easily readable.

Those were the original reasons, but I do not mind if you remove the example.

@mrdoob
Copy link
Owner

mrdoob commented Mar 4, 2020

Right.
Maybe we should modify it a bit so it doesn't something that can't be done with InstancedMesh alone.

@WestLangley
Copy link
Collaborator

I filed a PR to remove it so as not to compete with the newer InstancedMesh feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shader errors in webgl_buffergeometry_instancing_lambert
3 participants