PMREMGenerator: Fix viewport/scissor settings. #18447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the broken
PMREMGenerator
ondev
(for computer with device pixel ration > 1).@elalish When using
WebGLRenderer.setViewport()
, the viewport is automatically multiplied with the device pixel ratio e.g.:three.js/src/renderers/WebGLRenderer.js
Line 467 in 9518d5e
However, when you directly set
WebGLRenderTarget.viewport
andWebGLRenderTarget.scissor
, it's not necessary to divide through the device pixel ratio because it's not respected inWebGLRenderer.setRenderTarget()
.three.js/src/renderers/WebGLRenderer.js
Lines 2664 to 2665 in 9518d5e