-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ts typing for CSS2DRenderer in example/jsm/renderer ( JS file not converted yet ) #16342
Conversation
Awesome! Hand converting examples to jsm isn't currently sustainable because it requires maintaining both the original and new files as updates are made. For the moment I think it would be preferred to modify the modularize.js script to automatically convert the CSS2DRenderer files, instead. PR #15599 would enable a path forward for this type of manual conversion but it's unclear whether that will be merged. /cc @donmccurdy |
Um, when using |
Oh, I'm new to threejs, didn't know there is an auto converter, I will take a look at it. And I'm going to put two class into a single |
@Mugen87 I may sound a bit like a broken record but I would be concerned that updating and maintaining that script will be error prone if we try to support every case needed to convert every file. |
Yeah, makes sense. I just thought if it's possible to convert a given file with |
I agree we're going to need #15599 or something like it. I tried converting this file a while ago and hit the same problems. We started with everything in the global namespace, and we want to end up in a state where everything is an ES module and the legacy version is generated from that. Trying to create a middle step where every ES module can be generated from the global version automatically is a very tough – and avoidable – obstacle to the end goal. /cc @mrdoob see #15599 (comment) 😇 |
#16472 added BTW: The code base does not use the keywords Anyway, if you find a bug in the new TS files, it would be great if you make PRs with respective fixes^^. |
Glad to see those modules added, closing this PR. |
I just want to help
/jsm
to complete soonThis fixes #16337
Tested locally.