AudioLoader: Make decoding process more robust. #13725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, not sure about adding this logic to |
|
The approach in #13710, even if wasteful, seems like it creates less technical debt. |
Yes 😇
Yeah, it's definitely the easier fix although it does not solve #10706. Besides, the fix does not only clone the buffer (which allocates more memory), it also produces additional decode overhead. |
|
Closing. I'm trying to think of another approach that duplicates less code. Until then, let's focus on #13710. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem mentioned in #13710. It also fixes #10706, a bad race condition.
FileLoaderexecutes now a new callback function that can be used to decode the original response. This function can be set via.setDecodeCallback(). After the decode, the actualonLoad()fires.Not sure, this is the best solution. But at least we have an approach that solves the mentioned issues.