-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common.glsl: Introduce linearToRelativeLuminance() #12125
Conversation
@WestLangley I've just changed |
For now, I would just call the function If @bhouston feels strongly about keeping the name |
Okay! |
Let's make sure @bhouston finds this acceptable. |
It is for linear RGB color spaces, it isn't a general function. There is a different function for dealing sRGB or gamma corrected spaces, basically you need to decode sRGB or gamma RGB to linear and then apply this. So I much prefer the original name because it will remind people to be in linear space before using this conversion. |
Only two examples make use of I think only ToneMapShader needs a fix. |
Should be okay now! |
Thanks! |
see #11986