GLTFExporter: Added TRS and onlyVisible options #11977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandojsg
force-pushed
the
exportVisible
branch
from
392ae9d to
4c29357
Compare
mrdoob
reviewed
Aug 21, 2017
| @@ -57,7 +57,12 @@ THREE.GLTFExporter.prototype = { | |||
| */ | |||
| parse: function ( input, onDone, options ) { | |||
|
|
|||
| options = options || {}; | |||
| var DEFAULT_OPTIONS = { | |||
| trs: false, | |||
There was a problem hiding this comment.
@mrdoob yep, it was already implemented https://github.com/mrdoob/three.js/blob/dev/examples/js/exporters/GLTFExporter.js#L706-L730
fernandojsg
force-pushed
the
exportVisible
branch
from
4c29357 to
e4c2437
Compare
fernandojsg
force-pushed
the
exportVisible
branch
from
e4c2437 to
f868627
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two options to the exporter:
trs(Default:false): Exporttranslation,rotationandscaleinstead ofmatrix.onlyVisible(Default:true): Export only the nodes that are visible.