Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getRenderLists() method to WebGLRenderer #11497

Merged
merged 4 commits into from
Jun 14, 2017
Merged

Conversation

aardgoose
Copy link
Contributor

Allows internal renderer WebGLRendererLists to be accessed.

This allows: renderer.getRenderLists().dispose() to be used to release references to scene objects that are no longer in use but may be retained on the heap.

Ref issue #11478

@mrdoob
Copy link
Owner

mrdoob commented Jun 13, 2017

I think I would, instead, add a this.renderLists = renderLists; here:

https://github.com/mrdoob/three.js/blob/dev/src/renderers/WebGLRenderer.js#L343-L352

@aardgoose
Copy link
Contributor Author

Better?

@mrdoob mrdoob merged commit 5986c2d into mrdoob:dev Jun 14, 2017
@mrdoob
Copy link
Owner

mrdoob commented Jun 14, 2017

Thanks!

@aardgoose aardgoose deleted the renderlists branch June 14, 2017 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants