allow index attributes to be dropped using index.onUpload() mechanism. #11412
+8
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after upload to GPU.
mrdoob
reviewed
May 31, 2017
| @@ -14,24 +14,10 @@ function WebGLIndexedBufferRenderer( gl, extensions, infoRender ) { | |||
|
|
|||
| var type, size; | |||
|
|
|||
| function setIndex( index ) { | |||
| function setIndex( indexProperties ) { | |||
There was a problem hiding this comment.
Maybe we can rename this to setProperties( properties ), or even setType( value ) and setSize( value )?
There was a problem hiding this comment.
Or setIndexType( value ) and setIndexSize( value ).
There was a problem hiding this comment.
It's only called in one place as far as I know, so two functions seems like overkill.
setProperties() makes me wonder: set properties of what?
setIndexProperties() seems more logical to me?
There was a problem hiding this comment.
Okay, I'll merge and mess with variations.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow index attribute typed arrays to be dropped from javascript memory after upload to GPU.
Removes check of OES_index_element_uint, AFAICS if this check fails the index is treated as a byte array which won't produce the expected results anyway.