-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support FBX Binary format #11325
Support FBX Binary format #11325
Conversation
Many thankss! |
Hmm, any chance this could depend on http://stuk.github.io/jszip/ instead? That's what https://github.com/mrdoob/three.js/blob/dev/examples/js/loaders/KMZLoader.js and https://threejs.org/editor/ depends on already. |
OK, I'll try. (BTW who uses |
|
Hm, it seems JSZip's APIs aren't fitting to FBXLoader. |
So then it mainly needs https://github.com/imaya/zlib.js/blob/master/bin/rawinflate.min.js, right? What do you think about adding that code directly inside |
I can try, but personally I think I want to separate them for maintenance. |
Oks! Sounds good 👌 |
Some clean up... |
The loader doesn't seem to handling certain FBX files properly. I've attached an FBX file which I'm using to test it, and the model imports correctly in Unity3D, but the geometry doesn't load properly in the FbxLoader. Attaching screenshots for reference. @takahirox Would you be able to take a look at this? Note: The file unit is 1 unit = 1 mm, so you might want to adjust the camera far plane so you can see the entire object. |
Would you please check if text version of that model can be displayed correctly with |
@takahirox I just checked. ASCII version is also not displaying correctly. I suppose this is actually related to the Fbx -> THREE.Group conversion not handling certain cases. |
I see. |
Sure, will do. |
This PR lets
FBXLoader2
support FBX Binary format. #9860Binary model data can include compressed data.
You need to import
examples/libs/zlib_and_gzip.min.js
for such models.BTW does anyone have good FBX Binary model data which can be used as an example?