WebVR: Better availability check #11320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
.checkAvailability()
function in inWebVR.js
that uses a Promise in order to correctly check the availability of the WebVR API and HMDs..isAvailable()
returns just a boolean to indicate if WebVR is possible or not. The Promise returned by.checkAvailability()
will resolve if everything is fine. If something goes wrong, it rejects with a respective error message.This approach solves an important issue:
.isAvailable()
does not indicate if WebVR is supported but no HMD is available. Besides the current workflow does not provide an appropriate error message in this case because the following code is never reached (the value ofmessage
is determined in a callback, while the actual functiongetMessage
has already returned).