Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLShadowMap: fix directional light shadow updating #11314

Merged
merged 1 commit into from
May 14, 2017

Conversation

jaxry
Copy link
Contributor

@jaxry jaxry commented May 11, 2017

If a directional light shadow camera's frustrum is changed by the user, then the render function needs to be called twice for the shadow to be updated. This PR is a follow up to #11276 and fixes the bad order introduced with #11198.

I have tested directional lights, spotlights, and point lights by calling the render function only once. The shadows are now positioned correctly in each case.

@mrdoob mrdoob merged commit ed3c4c0 into mrdoob:dev May 14, 2017
@mrdoob
Copy link
Owner

mrdoob commented May 14, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants