fix operator precedence bug in WWOBJLoader2.js #11182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @kaisalmen |
|
Many thanks! |
|
Have you tried running the analyzer in /src? 😇 |
|
I ran it on everything including /src but I didn't find anything in there. I did find another minor thing in a unit test though, which I fixed in #11183. I'm still working on the static analyzer and I'll let you know if anything else comes up later :) |
|
Sweet! |
|
@evanw Thank you! I have fixed it in my repository as well. |
kaisalmen
added a commit
to kaisalmen/WWOBJLoader
that referenced
this pull request
Apr 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing a static analyzer for JavaScript and I noticed an operator precedence bug in this library during my testing. It turns out
!a instanceof bis parsed(!a) instanceof binstead of!(a instanceof b). You need to use parentheses around the operands to get it to parse correctly. I know it's a bug in one of the examples and not in the core library, but I figured you'd still appreciate me sending in a fix for it :)