-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimal implementation of caching logic #10149
Conversation
*/ | ||
|
||
var Cache = { | ||
|
||
enabled: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Why did you removed enabled
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the cache must be enabled permanently. This will eliminate the possibility of performing repeated requests for file downloads.
If you think that there must be an option to disable the cache, I will add this, but I think that the default set it enabled. What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to #6834
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the ability to enable or disable the cache
Added the ability to enable or disable the cache |
@vladgaidukov Just looking over this quickly - what improvements does it give over the current cache? |
@looeee In the current implementation, the file is cached only after downloading it. |
Resolved conflict: # src/loaders/FileLoader.js
Solved via #12434 |
update logic for lazy loading files