Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorAmbient in Blender generated JSON files isn't being handled #7486

Closed
Programmer-D opened this issue Oct 28, 2015 · 6 comments
Closed

colorAmbient in Blender generated JSON files isn't being handled #7486

Programmer-D opened this issue Oct 28, 2015 · 6 comments

Comments

@Programmer-D
Copy link

Versions:
Three.js: Updated from r71 to r73
Three.js blender exporter: Updated from 1.4.0 to 1.5.0
Blender: 2.76

Since I updated the Blender exporter and three.js, i decided to reexport my models. I now get the following error after loading the models:

Loader.createMaterial: Unsupported colorAmbient [0.64, 0.64, 0.64]
THREE.Loader.createMaterial @ three.js:14584
THREE.Loader.initMaterials @ three.js:14377
THREE.JSONLoader.parse @ JSONLoader.js:538
(anonymous function) @ JSONLoader.js:72
(anonymous function) @ three.js:14683

colorAmbient was present in my models before, and I never got this error in r71. I did a quick search in the r73 three.js code, but I didn't find a reference to it anywhere. The case statement where this error is generated from doesn't check for colorAmbient. As a test, I removed colorAmbient from the JSON files, and I didn't get the above error anymore.

Should colorAmbient be handled in three.js, or should it not be generated and put into the JSON files at all from the blender exporter?

@tschw
Copy link
Contributor

tschw commented Oct 29, 2015

Double-check whether the exporter is really from version r73.

@Programmer-D
Copy link
Author

It is. I actually completely reinstalled Blender to make sure there was no hint of the old exporter, and I now only have the r73 build, so that's the only exporter I could have put back into my new Blender installation. I also removed everything in the AppData\Roaming\Blender Foundation folder since that stuff didn't get removed when I installed Blender.

Were you not able to reproduce the problem? To reproduce it, I just export the default cube.

@tschw
Copy link
Contributor

tschw commented Oct 29, 2015

Nope. Mine is on the dev branch, though.

@mrdoob
Copy link
Owner

mrdoob commented Oct 29, 2015

Should colorAmbient be handled in three.js, or should it not be generated and put into the JSON files at all from the blender exporter?

It shouldn't be in the json. I think this has been fixed in dev already.

@tschw
Copy link
Contributor

tschw commented Oct 29, 2015

Yes, it's #7374

@Programmer-D
Copy link
Author

I checked out the dev branch and have confirmed that it is fixed there. r73 was tagged on Thursday, October 15, 2015 9:30:46 PM, and it appears the the fix was made on 10/18/2015 8:59:30 PM in revision d31d473, which shows the fix came after the release of r73.

I think this issue can be closed, but users should just be aware that they should pull the dev branch like I did if they want to use the blender exporter before r74 is released.

Thank you guys so much for your help!!! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants