Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example GUI checkbox may break scene state #22989

Closed
KurtPachinger opened this issue Dec 9, 2021 · 1 comment
Closed

Example GUI checkbox may break scene state #22989

KurtPachinger opened this issue Dec 9, 2021 · 1 comment

Comments

@KurtPachinger
Copy link

The page of Examples for Node-Based Material contains a preset entitled adv/toon. The examples will fail to display if the checkbox for ignoreIndirectLight is toggled multiple times (4+). A full page refresh is required.

https://threejs.org/examples/webgl_materials_nodes.html

Android Pixel 3a

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 9, 2021

I can reproduce. The following runtime error is logged:

Uncaught TypeError: Failed to execute 'uniform3fv' on 'WebGL2RenderingContext': Overload resolution failed.
at SingleUniform.setValueV3f [as setValue] (three.module.js:17226)
at Function.WebGLUniforms.upload (three.module.js:17991)
at setProgram (three.module.js:27030)
at WebGLRenderer.renderBufferDirect (three.module.js:26008)
at renderObject (three.module.js:26606)
at renderObjects (three.module.js:26575)
at renderScene (three.module.js:26515)
at WebGLRenderer.render (three.module.js:26327)
at animate (webgl_materials_nodes.html:3373)

/ping @sunag

sunag added a commit to sunag/three.js that referenced this issue Dec 22, 2021
mrdoob pushed a commit that referenced this issue Dec 22, 2021
* fix keyword example

* fix NodeMaterial ColorSpace: #22998

* variable params.length to ARCTAN: #22930

* NodeMaterial: fix CLEARCOAT

* possible fix to: #23054

* fix NodeMaterial: toon example: #22989
@mrdoob mrdoob closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants