Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 'webgl_morphnormals' consumes all memory #12474

Closed
5 of 12 tasks
moraxy opened this issue Oct 23, 2017 · 6 comments
Closed
5 of 12 tasks

Example 'webgl_morphnormals' consumes all memory #12474

moraxy opened this issue Oct 23, 2017 · 6 comments

Comments

@moraxy
Copy link
Contributor

moraxy commented Oct 23, 2017

Description of the problem

The webgl_morphnormals example starts out normal i.e. GUI is loading fine etc., but it then never shows the two flamingos and instead very quickly eats up all the available memory.
Current r87/homepage is fine, current dev is not.

Three.js version
  • Dev
  • r87
Browser
  • All of them
  • Chrome (v62.0.3202.62 Linux, v61.0.3163.100 Windows)
  • Firefox (v56 both)
  • Internet Explorer (possibly, can't test)
OS
  • All of them
  • Windows
  • macOS
  • Linux
  • Android
  • iOS
Hardware Requirements (graphics card, VR Device, ...)
@takahirox
Copy link
Collaborator

#12458 fixes this issue.

@moraxy
Copy link
Contributor Author

moraxy commented Oct 23, 2017

I'm still seeing the same effect after applying #12458 locally, as well as via the rawgit preview - is there any other PR I'm missing?

@takahirox
Copy link
Collaborator

You need to update build by running npm run build

@moraxy
Copy link
Contributor Author

moraxy commented Oct 23, 2017 •
edited by WestLangley
Loading

what a rookie mistake 😞
yeah #12458 fixes it, thank you

@moraxy moraxy closed this as completed Oct 23, 2017
@takahirox
Copy link
Collaborator

Just in case, would you please keep this issue open until #12458 is merged?

@moraxy moraxy reopened this Oct 23, 2017
@mrdoob
Copy link
Owner

mrdoob commented Oct 23, 2017

Seems to fix it on my end 🎉

@mrdoob mrdoob closed this as completed Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrdoob @moraxy @takahirox