Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FileLoader duplicate request issues #12458

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Fix FileLoader duplicate request issues #12458

merged 1 commit into from
Oct 23, 2017

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Oct 21, 2017 •
edited
Loading

This PR fixes the following FileLoader duplicate request issues reported in #12454

  • onProgress, onError aren't called for duplicate requests
  • duplicate request isn't handled correctly when Cache.enabled is false

/cc @mrdoob @ngokevin @bananer

This was referenced Oct 23, 2017
Closed
Closed
@mrdoob mrdoob merged commit f6d33e8 into mrdoob:dev Oct 23, 2017
@mrdoob
Copy link
Owner

mrdoob commented Oct 23, 2017

Thanks!

@mrdoob mrdoob mentioned this pull request Oct 23, 2017
Closed
@takahirox takahirox deleted the FixFileLoader branch October 24, 2017 01:13
@kaisalmen kaisalmen mentioned this pull request Jan 29, 2018
Closed
5 tasks
This was referenced Mar 28, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahirox @mrdoob