Removed .isBlack() method (#22385)

mrdoob · Aug 21, 2021 · 4b26288 · 4b26288
1 parent 588bc49
commit 4b26288
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/docs/api/en/math/Color.html b/docs/api/en/math/Color.html
@@ -208,9 +208,6 @@ <h3>[method:Object getHSL]( [param:Object target] )</h3>
 		<h3>[method:String getStyle]()</h3>
 		<p>Returns the value of this color as a CSS style string. Example: 'rgb(255,0,0)'.</p>
 
-		<h3>[method:Boolean isBlack]() </h3>
-		<p>Returns true if the [page:.r r], [page:.g g] and [page:.b b] components are zero, false otherwise.</p>
-
 		<h3>[method:Color lerp]( [param:Color color], [param:Float alpha] ) </h3>
 		<p>
 		[page:Color color] - color to converge on.<br />

diff --git a/src/math/Color.js b/src/math/Color.js
@@ -546,12 +546,6 @@ class Color {
 
 	}
 
-	isBlack() {
-
-		return ( this.r === 0 ) && ( this.g === 0 ) && ( this.b === 0 );
-
-	}
-
 	fromArray( array, offset = 0 ) {
 
 		this.r = array[ offset ];

diff --git a/src/renderers/webgl/WebGLPrograms.js b/src/renderers/webgl/WebGLPrograms.js
@@ -204,7 +204,7 @@ function WebGLPrograms( renderer, cubemaps, cubeuvmaps, extensions, capabilities
 
 			gradientMap: !! material.gradientMap,
 
-			sheenTint: ( !! material.sheenTint && ! material.sheenTint.isBlack() ),
+			sheenTint: ( !! material.sheenTint && ( material.sheenTint.r > 0 || material.sheenTint.g > 0 || material.sheenTint.b > 0 ) ),
 
 			transmission: material.transmission > 0,
 			transmissionMap: !! material.transmissionMap,