GCP: Implement SupportsRecoveryOperations for GCSFileIO #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcnc
force-pushed
the
implement-recover-file-for-gcsfileio
branch
12 times, most recently
from
b5c5ba3 to
dba27d1
Compare
mrcnc
force-pushed
the
implement-recover-file-for-gcsfileio
branch
from
dba27d1 to
288152f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the initial implementation in S3FileIO, this PR implements
SupportsRecoveryOperationsfor GCSFileIO.GCP recommends using soft-delete instead of object versioning, so this implementation attempts to restore a soft-deleted object first. If soft-delete is not enabled (which may be common since it's a relatively new feature), then it attempts to restore a previously deleted version by coping it to the live location, similar to the S3FileIO implementation.