perf: optimize target_arch switching #548
Conversation
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
|
improved target switching and reduced nested callbacks @mrcjkb |
Head branch was pushed to by a user without write access
mrcjkb
changed the title
lua/rustaceanvim/rust_analyzer.lua
Outdated
| if filter and filter.exclude_rustc_target then | ||
| clients = vim.tbl_filter(function(client) | ||
| local cargo_target = vim.tbl_get(client, 'config', 'settings', 'rust-analyzer', 'cargo', 'target') | ||
| if filter.exclude_rustc_target == DEFAULT_RUSTC_TARGET and cargo_target == nil then |
There was a problem hiding this comment.
issue: DEFAULT_RUSTC_TARGET is in the rustc module (ditto for the other usages).
tip: If you have Nix installed, I recommend you enter a nix devShell (nix develop) and run pre-commit run --all-files.
It will run all the type checks and lints needed to catch these issues.
Otherwise, you can run luacheck and the lua-language-server CLI to get the lints without using Nix.
lua/rustaceanvim/lsp/init.lua
Outdated
| local clients = rust_analyzer.get_active_rustaceanvim_clients(bufnr) | ||
| local clients = rust_analyzer.get_active_rustaceanvim_clients( | ||
| bufnr, | ||
| { exclude_rustc_target = exclude_rustc_target or DEFAULT_RUSTC_TARGET } |
There was a problem hiding this comment.
issue: The stop function shouldn't set a rustc target by default, otherwise it will always try to filter, even when we don't need it to.
| { exclude_rustc_target = exclude_rustc_target or DEFAULT_RUSTC_TARGET } | |
| { exclude_rustc_target = exclude_rustc_target } |
There was a problem hiding this comment.
yeah make sense. thanks
lua/rustaceanvim/lsp/init.lua
Outdated
| ---@param target? string The target architecture. Defaults to nil(the current buffer's target if not provided). | ||
| M.set_target_arch = function(bufnr, target) | ||
| ---@param exclude_rustc_target? string Cargo target triple (e.g., 'x86_64-unknown-linux-gnu') to filter rust-analyzer clients | ||
| M.set_target_arch = function(bufnr, exclude_rustc_target) |
There was a problem hiding this comment.
issue: Here (just not in stop/restart), the parameter should be called target, as it's the target we want to set, not a target we want to exclude.
#543