mrc-4547 Use new batch API in preparation for multi-sensitivity #178
Conversation
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Code looks good and everything works well! I did discover a bug from my side actually (implementation of advanced settings) it doesnt update run required when changed on fit and sensitivity tabs, only run tab! created a ticket and will fix asap!
| @@ -88,6 +89,9 @@ export default defineComponent({ | |||
| const time = { | |||
| mode: "grid" as const, tStart: start, tEnd: end, nPoints: points | |||
| }; | |||
| const varyingParamName = paramSettings.value.parameterToVary; | |||
| const varyingPar = pars.varying.filter((v: VaryingPar) => v.name === varyingParamName); | |||
There was a problem hiding this comment.
oh btw, completely aside from the review, idk if you know this, i learnt it like a tiny bit ago, you can get the type of the store and you wont have to annotate these filters or maps or anything you get from the store with a type, you just have to do const store = useStore<AppState>() when you define store! Idk if theres any disadvantage to doing this let me know, I might start doing this in some places if not
There was a problem hiding this comment.
Yeah, I always forget to do it!
scripts/run-dependencies.sh
Outdated
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
| set -ex | |||
|
|
|||
| ODIN_API_BRANCH=main | |||
| ODIN_API_BRANCH=odin-js-0-1-2 | |||
This branch updates WODIN to use the new odin-js batch running API to support multi-sensitivity. The key difference are:
BatchParsno longer has a singlenameandvaluesprops, but instead supports multiple varying parameters, with avaryingprop of typeVaryingPar[], each of which specifiesnameandvalue`OdinUserTypeSeriesSetwhere thexvalues are not numeric parameter values, but instead areUserTypes, each of which specifies values for all the varying parameters.There are no functionality changes in this branch, everything should work as before.
There's a chain of branches which should be merged and updated as follows when this branch is merged:
scripts/update_js, then mergeDESCRIPTION, and mergeODIN_APIto main inscripts/run-dependencies.shbefore merging