Merge pull request #230 from mrc-ide/mrc-5970

mrc-5970 lint, codecov and other friends

.github/workflows/test.yml

@@ -9,7 +9,7 @@ jobs:
         with:
           node-version: 20.x
       - name: Install dependencies
-        run: npm install -g typescript codecov
+        run: npm install -g typescript
       - name: Build
         run: ./scripts/build.sh
       - name: Run dependencies
@@ -21,16 +21,15 @@ jobs:
       - name: Test back end integration
         run: npm run integration-test --prefix=app/server
       - name: Test front end
-        run: npm run test:unit --prefix=app/static
+        run: npm run coverage --prefix=app/static
       - name: Lint back end
         run: npm run lint --prefix=app/server
       - name: Lint front end
         run: npm run lint --prefix=app/static
-      - name: Check formatting frontend
-        run: npm run format:check --prefix=app/static
       - name: Check versions
         run: npm run genversion --prefix=app/server -- --check-only
-      - name: Upload coverage
-        run: |
-          codecov -f app/static/coverage/*.json
-          codecov -f app/server/coverage/*.json
+      - uses: codecov/codecov-action@v4
+        with:
+          fail_ci_if_error: true # optional (default = false)
+          files: ./app/server/coverage/coverage-final.json,./app/static/coverage/coverage-final.json
+          token: ${{ secrets.CODECOV_TOKEN }} # required

.gitignore

@@ -2,7 +2,6 @@
 /app/server/coverage/
 /app/server/node_modules/
 /app/server/public/
-!/app/server/public/favicon.ico
 /app/server/dist/
 /app/static/node_modules/
 /app/static/coverage/

.nvmrc

@@ -1 +1 @@
-v16
+v20

app/static/eslint.config.js

@@ -23,16 +23,19 @@ export default [
   },
 
   {
-    files: ["**/*.ts", "**/*.vue"],
+    files: ["src/**/*.ts", "src/**/*.vue"],
     rules: {
-      "@typescript-eslint/no-explicit-any": "off"
+      "@typescript-eslint/no-explicit-any": "error",
+      "@typescript-eslint/no-unused-vars": "error",
+      "vue/no-setup-props-destructure": "error",
     }
   },
 
   {
     files: ["**/tests/**/*.ts"],
     rules: {
-      "vitest/expect-expect": "off"
+      "vitest/expect-expect": "off",
+      "@typescript-eslint/no-explicit-any": "off",
     }
   },