Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-4462: more cli errors #91

Merged
merged 5 commits into from
Aug 23, 2023
Merged

mrc-4462: more cli errors #91

merged 5 commits into from
Aug 23, 2023

Conversation

richfitz
Copy link
Member

Just goes through and replaces more stop() errors with cli::cli_abort(); there are more of these to come, and I'm just focussing on the ones most likely to be seen by users when running things

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2436972) 100.00% compared to head (193f508) 100.00%.

❗ Current head 193f508 differs from pull request most recent head 89811cd. Consider uploading reports for the commit 89811cd to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         3068      3089   +21     
=========================================
+ Hits          3068      3089   +21     
Files Changed Coverage Δ
R/config.R 100.00% <100.00%> (ø)
R/metadata.R 100.00% <100.00%> (ø)
R/outpack_metadata.R 100.00% <100.00%> (ø)
R/outpack_misc.R 100.00% <100.00%> (ø)
R/outpack_packet.R 100.00% <100.00%> (ø)
R/query_search.R 100.00% <100.00%> (ø)
R/root.R 100.00% <100.00%> (ø)
R/run.R 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz richfitz marked this pull request as ready for review August 23, 2023 08:21
@richfitz richfitz requested a review from r-ash August 23, 2023 08:21
@r-ash r-ash merged commit 9a1c9ec into main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants